Remove dead Ready and lastEventTime fields - #94
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
Ready is only ever written, never read, and is not exposed on the Node interface so no consumer can reach it either. lastEventTime has the same shape: a dedicated mutex guarding a field nobody reads. Neither has any effect on behavior, they're just state nothing observes. No new test needed here since this removes unreachable state rather than changing behavior; the existing suite passing is the regression check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ready is only ever written, never read, and isn't exposed on the Node interface, so no consumer can reach it either. lastEventTime has the same shape: a dedicated mutex guarding a field nobody reads. Neither affects behavior, they're just state nothing observes.
Test plan